Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #79 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to comment #78) > Koji scratch build also has some issues with %fedora usage, > https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds > May be this is one more reason to split these files. But, I'm fine to keep > the spec file as it is till review is going on. Yes, I usually build locally with mock as it's faster, and then submit the package. If the package fails to build you don't need necessarily to bump the release for a rebuild as if the package was built correctly, so it's pretty safe. All the points have been fixed, so for me the package is good to go; Good job :) We have only to solve the licensing issues. Have you had a change to read this? https://fedoraproject.org/wiki/Licensing:FAQ It lists common cases with multiple licensing scenarios. I think the best thing you could do is make another upstream release with the following: - leverage licenses across the files - fix the make check target - fix the compilation problems - add the driver notes to the README file as your comment #38 Bump the release and it will get approved. Otherwise since all the licenses seem compatible with each other please find a way to write it down in the License field in the spec file using the above link. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6mRyYbRG36&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review