Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-05 07:10 EST ------- MUSTFIXes: missing BR gettext,desktop-file-utils GOOD - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest available version, sha1sum d1ba549ebff68157912b41e332941d84836d1fbb gtk-recordmydesktop-0.3.3.1.tar.g - package compiles on devel (x86_64) [*] - no unnecessary BR - locales properly handled [*] - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for separate -docs - nothing in %doc affects runtime - there are no scriptlets, no static code, no libtool/pkgconfig files SHOULD: - the package compiles and builds into binary rpms on FC6 and rawhide (tested only on x86_64); generated binary is a noarch so no issues should exist for x86 [*] - the package runs as advertised [*] [*] after adding the missing BRs Sindre, please fix the spec adding the missing BRs and I'll reverify/approve the package. As a sidenote, in the future I think it would be a good ideaif you would test your packages using rpmlint and by bulding in mock before submitting them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review