Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #72 from Jerry James <loganjerry@xxxxxxxxx> --- > (In reply to comment #63) > Should I keep this chunk btw? Same issue as other review: > ---%<--- > %post > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > %postun > if [ $1 -eq 0 ] ; then > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > fi > > %posttrans > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > ---%<--- > because the icon is actually installed under %{_datadir}/pixmaps, or > should the icon be moved elsewhere (under %{_datadir}/pixmaps). You don't need this for an icon installed in %{_datadir}/pixmaps. I don't yet understand the relative merits of installing an icon in %{_datadir}/pixmaps versus %{_datadir}/icons/hicolor. If somebody out there knows, please share that information. (In reply to comment #71) > Jerry FWIW I think that this package is in a state where it is ready to be > approved. Thanks, I do, too. This package is APPROVED.(In reply to comment #64) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2B1rap18b2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review