Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: recordmydesktop - Desktop session recorder with audio and video https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230891 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-05 05:58 EST ------- Good: - rpmlint checks do not return anything on source and binary rpm; the debuginfo package reports: W: recordmydesktop-debuginfo spurious-executable-perm /usr/src/debug/recordmydesktop-0.3.3.1/src/load_cache.c W: recordmydesktop-debuginfo spurious-executable-perm /usr/src/debug/recordmydesktop-0.3.3.1/include/rmdtypes.h W: recordmydesktop-debuginfo spurious-executable-perm /usr/src/debug/recordmydesktop-0.3.3.1/src/cache_frame.c Probably a chmod -x on these three files in %prep should make rpmlint happy. - package meets naming guidelines - package meets packaging guidelines - license (GPL) is OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest version, sha1sum 3eb2ffe79a0fcf5e04962bd3d120c1e5587c178b recordmydesktop-0.3.3.1.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all file/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok (see rpmlint output on -debuginfo above) - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - not a GUI, so no need for .desktop file - no need for a separate -devel package - no .la files - no scriptlets - no static files SHOULD: - builds in mock for devel/x86_64 - works as advertised APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review