Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: arptables_jf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225255 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-05 05:18 EST ------- MUSTFIX - Epoch tag can be removed (0 is the default value) - BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n - no URL provided - "BuildPrereq: /usr/bin/perl" can be removed, perl is on the exception list; if you plan to keep it then you should use "BuildRequires(pre)" (and eventually explain why you explicitely want it ) - "Requires(post,postun): chkconfig" should be split in Requires(post), Requires(postun) - You should stick with either %{buildroot} or $RPM_BUILD_ROOT but not both - "rm -rf %{buildroot}" is not needed in %prep - "rm -rf $RPM_BUILD_ROOT" is missing in %install - "service" should be added to Requires - Missing SMP flags. If it doesn't build with it, please add a comment - $RPM_OPT_FLAGS is not used - "%config /etc/rc.d/init.d/arptables_jf" should use a macro, not a fixed path SHOULD FIX - Summary ended with dot - adding "INSTALL="%{__install} -c -p" to the make install line would preserve timestamps rpmlint has some info for us, too: rpmlint of arptables_jf: W: arptables_jf summary-ended-with-dot Userspace control program for the arptables network filter. W: arptables_jf no-url-tag - We know about these two already W: arptables_jf conffile-without-noreplace-flag /etc/rc.d/init.d/arptables_jf E: arptables_jf executable-marked-as-config-file /etc/rc.d/init.d/arptables_jf - /etc/rc.d/init.d/arptables_jf should not be marked as %config; could be left as such till F8T1 according to last week's guidelines W: arptables_jf service-default-enabled /etc/rc.d/init.d/arptables_jf - that's a good point. Do we need/want it enabled at start time? E: arptables_jf incoherent-subsys /etc/rc.d/init.d/arptables_jf arptables E: arptables_jf incoherent-subsys /etc/rc.d/init.d/arptables_jf arptables E: arptables_jf incoherent-subsys /etc/rc.d/init.d/arptables_jf arptables - Harmless, but maybe should be discussed. Why is the package called arptables_jf and not arptables ? W: arptables_jf no-reload-entry /etc/rc.d/init.d/arptables_jf - harmless, although a reload which does just start+stop would be easy to implement -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review