[Bug 953384] Review Request: Review Request: unar - Multi-format extracter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953384

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #7 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
$ rpm -qpl unar-1.6-1.fc20.x86_64.rpm
/usr/bin/lsar
/usr/bin/unar
/usr/share/bash-completion/completions
/usr/share/bash-completion/completions/lsar
/usr/share/bash-completion/completions/unar
/usr/share/doc/unar-1.6
/usr/share/doc/unar-1.6/License.txt
/usr/share/man/man1/lsar.1.gz
/usr/share/man/man1/unar.1.gz

The folder /usr/share/bash-completion/completions is already owned by the
bash-completion package. The correct entry in %files has to be:

%{_datadir}/bash-completion/completions/*

You have to add bash-completion to the runtime requirements, or you split out
the completion stuff into a subpackage which contains the appropriate files and
pulls bash-completion as requirement. It depends on if unar will work properly
without the bash-completion files, I haven't tested it.


Moreover, there are some typos in summary and description:

extracing → extracting
extracter → extractor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u0m2pF0WJG&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]