Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913289 --- Comment #8 from Peter Hanecak <hany@xxxxxxx> --- (In reply to comment #4) > C/C++: <shortened> > Generic: <shortened> > [!]: Package contains no bundled libraries. sRGB.cc should not be bundled > because colord already provides it. Perhaps addid colord-devel as build > require? I'm not able to find sRGB.cc in gimp-separate, nor in colord-devel. But, there is sRGB_type2.icc in gimp-separate+ and sRGB in colord, but those are different: f152537f3d0aa328325a37f468f843ff46133c07 sRGB.icc 3eff12b5237bfaa6ca9d6dfada2dada8b632672a sRGB_type2.icc Can you please clarify? <shortened> > [!]: Buildroot is not present > Note: Multiple BuildRoot definitions found Ops, typo. Sorry, duplicate entry removed. > [!]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: %clean present but not required There is following in the SPEC: %clean rm -rf %{buildroot} So I left it as it is in newr package. <shortened> > [!]: SourceX / PatchY prefixed with %{name}. > Note: Source0 (separate+-0.5.8.zip) I'm not sure what to do with this one: package is named hopefully in line with what Fedora users would expect (gimp-<splugin name>) even though upstream is named differently (just <plugin name>). I can't rename upstream and I'm reluctant to rename the package. <shortened> > [!]: Spec use %global instead of %define. > Note: %define gimpver 2.8.0 %define _gimppluginsdir > %{_libdir}/gimp/%{gimpver}/plug-ins Changed %define into %global . <shortened> > Unknown or generated > -------------------- > /var/lib/mock/fedora-18-x86_64/root/builddir/build/BUILD/separate+-0.5.8/ > iccclassicons.h > > Could you check which license iccclassicons.h use? I've tried to check with upstream (question sent on March 13th), no reply so far. File contains following: GdkPixbuf RGBA C-Source image dump 1-byte-run-length-encoded Based on that I think the header file is generated using gdk-pixbuf-csource (http://www.gtk.org/api/2.6/gdk-pixbuf/gdk-pixbuf-csource.html or older version). Source icon image is nowhere to be found in the package. Thus I think following section in README applies: ----- License The plug-ins and scripts included in this package are licensed under the GNU General Public License version 2. For more information, see COPYING. Updated package and spec can be found here: http://hany.sk/~hany/_data/fedoraproject/gimp-separate+.spec http://hany.sk/~hany/_data/fedoraproject/gimp-separate+-0.5.8-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OtIchd9pT5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review