Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952632 Micah Roth <micah.roth@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |micah.roth@xxxxxxxx --- Comment #1 from Micah Roth <micah.roth@xxxxxxxx> --- Dear tieugene, This is my very first review, so this is unofficial. But I was very carefully walked through the process by an some experienced people (thanks volter and nirik!), so I think you will find it useful. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qtermwidget-devel ## See: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_base_package; you are missing the %{?_isa} macro and the %{release} macro in your string. [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/makerpm/952632-qtermwidget/licensecheck.txt ## This probably qualifies as a Multiple Licencing Scenario: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios you should add the other licenses to your License: string, with "and"s between them. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 4 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Dist tag is present. ## Add the %{?dist} macro to your Release string. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). ## %{_libdir}/qt4/plugins/designer/lib%{name}plugin.so should be under %files, not '%files devel' [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qtermwidget-0.4.0-1.i686.rpm qtermwidget-devel-0.4.0-1.i686.rpm qtermwidget.i686: W: spelling-error %description -l en_US embeddable -> embedded qtermwidget-devel.i686: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint qtermwidget qtermwidget-devel qtermwidget.i686: W: spelling-error %description -l en_US embeddable -> embedded qtermwidget.i686: W: unused-direct-shlib-dependency /usr/lib/libqtermwidget.so.0.4.0 /lib/libm.so.6 qtermwidget-devel.i686: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- qtermwidget (rpmlib, GLIBC filtered): /sbin/ldconfig libQtCore.so.4 libQtGui.so.4 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) qtermwidget-devel (rpmlib, GLIBC filtered): libQtCore.so.4 libQtDesigner.so.4 libQtDesignerComponents.so.4 libQtGui.so.4 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libqtermwidget.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) qtermwidget rtld(GNU_HASH) Provides -------- qtermwidget: libqtermwidget.so.0 qtermwidget qtermwidget(x86-32) qtermwidget-devel: libqtermwidgetplugin.so qtermwidget-devel qtermwidget-devel(x86-32) MD5-sum check ------------- https://github.com/qterminal/qtermwidget/archive/0.4.0.tar.gz : CHECKSUM(SHA256) this package : cb279e8389133ceca00feece59568d9e2c4dab273ff7d295c225cf0f713c68e9 CHECKSUM(SHA256) upstream package : cb279e8389133ceca00feece59568d9e2c4dab273ff7d295c225cf0f713c68e9 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-18-i386 Command line :/usr/bin/fedora-review -b 952632 ## "Environment" may not be the best term for your -devel package %description, won't just "development files for..." work? Might confuse some users searching for "desktop environment" or something like that. ## Should include some indicator of what your patch file does and what action with upstream you have taken, see: http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TGJOpsXT2m&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review