[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951874

--- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> ---
Missing buildtime deps:
  perl(base), ./inc/FirebirdMaker.pm:6, ./t/TestFirebird.pm:22,
./TestFirebirdEmbedded.pm:17
  perl(Carp), ./Makefile.PL:63, ./Firebird.pm:13, ./Firebird.pm:163,
./t/TestFirebirdEmbedded.pm:8, 
  perl(constant), ./t/TestFirebird.pm:31-33, ./t/TestFirebirdEmbedded.pm:27-28,
./t/dbi-table_info.t:17,42
  perl(Data::Dumper), ./t/91-txinfo.t:7
  perl(DBI::DBD), ./Makefile.PL:184
  perl(Encode), ./t/75-utf8.t:17
  perl(Exporter), ./inc/FirebirdMaker.pm:6, ./Firebird.pm:17,
./lib/DBD/Firebird/TypeInfo.pm:13, ./t/TestFirebird.pm:22,
./t/TestFirebirdEmbedded.pm:17
  perl(File::Temp), ./t/TestFirebird.pm:18, ./t/TestFirebirdEmbedded.pm:13
  perl(Getopt::Long), ./Makefile.PL:66
  perl(lib), most tests
  (+ Config, DynaLoader, File::Basename, File::Spec, Math::BigFloat, POSIX,
strict, utf8, vars, warnings; see the same comment in DBD::InterBase)

Perl v5.10.1 is required (./Firebird.pm:9), therefore your perl >= 5.8.1 BR is
incorrect.  This is another reason why this can't go to EPEL5.  I also think
specifying the version here is not necessary.

%defattr is not required, could be dropped.

The same for line 35.

You could add the 'eg' directory to %doc.

Since this isn't going to EPEL5, drop the Buildroot-related stuff.  It's not
needed. (lines 17, 31, 42, and 43)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xASC8wynYh&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]