Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951873 --- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> --- Please, submit perl-DBD-InterBase-0.48-perl_514.patch upstream if you haven't already (I can't see it listed on RT). More people could benefit from this. %defattr is not required (not even in EPEL) and could be dropped. The same probably applies to line 39 but I'm not sure about it; please check. You're missing some build-time deps: perl(Carp), ./InterBase.pm:14, ./InterBase.pm:135 perl(Data::Dumper), t/31prepare.t:8, t/91txinfo.t:8 perl(Exporter), ./InterBase.pm:18, lib/DBD/InterBase/TypeInfo.pm:16 perl(threads), t/80event-ithreads.t:103 (recommended) (+ Config, DynaLoader, POSIX, strict, and vars -- those don't dual-live yet but might in the future; it's up to you) I'm not sure about the license of this package, quoting: You may distribute under the terms of either the GNU General Public License or the Artistic License, as specified in the Perl README file, with the exception that it cannot be placed on a CD-ROM or similar media for commercial distribution without the prior approval of the author. I'll ask fedora-legal if such exception is alright in our case. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WgHNc77QpB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review