Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #74 from Simone Caronni <negativo17@xxxxxxxxx> --- Issues: ======= - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in open-vm-tools See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries Please use /sbin/ldconfig as suggested so it works also with Epel. [!]: Spec use %global instead of %define. Note: %define majorversion 9.2 %define minorversion 2 %define toolsbuild 893683 %define toolsversion %{majorversion}.%{minorversion} %define toolsdaemon vmtoolsd Please check this and apply where appropriate: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files This happens to me again on the review! I've checked the Makefile in the docs folder; the check is rebuilding the docs. So let's remove the %check section as it's not mandatory and causes more trouble than anything else. [!]: Package should compile and build into binary rpms on all supported architectures. Does not build on Fedora 19 with the error explained in comment #62. open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libvmtools.so.0.0.0 open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libvmtools.so.0.0.0 open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libguestlib.so.0.0.0 open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libguestlib.so.0.0.0 open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libhgfs.so.0.0.0 open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libhgfs.so.0.0.0 Plase use /sbin/ldconfig as described above. open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/pam.d/vmtoolsd open-vm-tools.x86_64: E: script-without-shebang /etc/pam.d/vmtoolsd This should not be executable. open-vm-tools.x86_64: W: install-file-in-docs /usr/share/doc/open-vm-tools-9.2.2/INSTALL Please remove from %doc line. open-vm-tools-desktop.x86_64: E: summary-too-long C User experience components for Open VMware Tools for virtual machines hosted on VMware Please shorten (21 charachters maximum if I remember correctly). open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libvmtools.so.0.0.0 /lib64/libcrypt.so.1 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libvmtools.so.0.0.0 /lib64/libicudata.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libvmtools.so.0.0.0 /lib64/libm.so.6 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/librt.so.1 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libcrypt.so.1 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libicui18n.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libicuuc.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libicudata.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libpthread.so.0 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libdl.so.2 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libm.so.6 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguestlib.so.0.0.0 /lib64/libglib-2.0.so.0 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libgthread-2.0.so.0 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/librt.so.1 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libcrypt.so.1 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libicui18n.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libicuuc.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libicudata.so.49 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libdl.so.2 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libm.so.6 open-vm-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libhgfs.so.0.0.0 /lib64/libglib-2.0.so.0 Please see: https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jefpLdvXNY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review