[Bug 920037] Review Request: maven-jsf-plugin - Maven plugin for generating tlds, jsp tag sources and others

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920037

--- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> ---
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Packages have proper BuildRequires/Requires on jpackage-utils
  See: https://fedoraproject.org/wiki/Packaging:Java
- Pom files have correct add_maven_depmap call
  Note: No add_maven_depmap calls found but pom files present
  See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 2 files have unknown license.
     Detailed output of licensecheck in /home/gil/920037-maven-jsf-
     plugin/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

Java:
[x]: Package has BuildArch: noarch (if possible)
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: maven-jsf-plugin-1.2.3-1.fc19.noarch.rpm
maven-jsf-plugin.noarch: W: spelling-error Summary(en_US) tlds -> teds, tads,
tildes
maven-jsf-plugin.noarch: W: spelling-error Summary(en_US) jsp -> esp, asp, tsp
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US tlds -> teds,
tads, tildes
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US jsp -> esp,
asp, tsp
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US config -> con
fig, con-fig, configure
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US xml -> XML,
ml, x ml
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US facelets ->
faceless, face lets, face-lets
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US taglib -> ta
glib, ta-glib, tag lib
maven-jsf-plugin.noarch: W: incoherent-version-in-changelog 1.2.3-2
['1.2.3-1.fc19', '1.2.3-1']
1 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint maven-jsf-plugin
maven-jsf-plugin.noarch: W: spelling-error Summary(en_US) tlds -> teds, tads,
scolds
maven-jsf-plugin.noarch: W: spelling-error Summary(en_US) jsp -> esp, asp, tsp
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US tlds -> teds,
tads, scolds
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US jsp -> esp,
asp, tsp
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US config -> con
fig, con-fig, configure
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US xml -> XML,
ml, x ml
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US facelets ->
faceless, face lets, face-lets
maven-jsf-plugin.noarch: W: spelling-error %description -l en_US taglib -> ta
glib, ta-glib, tag lib
maven-jsf-plugin.noarch: W: incoherent-version-in-changelog 1.2.3-2
['1.2.3-1.fc19', '1.2.3-1']
1 packages and 0 specfiles checked; 0 errors, 9 warnings.
# echo 'rpmlint-done:'



Diff spec file in url and in SRPM
---------------------------------
--- /home/gil/920037-maven-jsf-plugin/srpm/maven-jsf-plugin.spec    2013-04-17
08:30:20.223921338 +0200
+++ /home/gil/920037-maven-jsf-plugin/srpm-unpacked/maven-jsf-plugin.spec   
2013-04-17 08:30:21.293865023 +0200
@@ -32,5 +32,5 @@

 %build
-%mvn_build
+%mvn_build -f

 %install


Requires
--------
maven-jsf-plugin (rpmlib, GLIBC filtered):
    java
    jpackage-utils
    mvn(commons-digester:commons-digester)
    mvn(commons-lang:commons-lang)
    mvn(org.apache.maven:maven-plugin-api)
    mvn(org.apache.maven:maven-project)



Provides
--------
maven-jsf-plugin:
    maven-jsf-plugin
    mvn(org.primefaces:maven-jsf-plugin)



MD5-sum check
-------------
http://www.apache.org/licenses/LICENSE-2.0.txt :
  CHECKSUM(SHA256) this package     :
cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30
  CHECKSUM(SHA256) upstream package :
cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30



fix this problem
maven-jsf-plugin.noarch: W: incoherent-version-in-changelog 1.2.3-2
['1.2.3-1.fc19', '1.2.3-1']

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X42ZiIOmB8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]