[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905255

--- Comment #63 from Ravindra Kumar <ravindrakumar@xxxxxxxxxx> ---
> Your analysis must be wrong somewhere.  %check runs after
> the RPM has been built, so it shouldn't matter if %check runs
> doxygen again.

I have verified this with 'rpmbuild --nocheck' as well. I have done following
analysis with the SPEC file from dropbox (please note that this SPEC file has
a step to remove font file in %install section as well as in %check section):

1. I remove the step to remove font file 'rm docs/api/build/html/FreeSans.ttf'
from %check section, the font file gets included in the devel rpm.
2. I inserted debug checks to see existence of this file before and after
'make check' and found that file was not present before 'make check', but it
was present after 'make check'.
3. Running rpmbuild with '--nocheck' does not include the font file in the
package.

> It's quite possible that 'make install' runs doxygen (it would
> be an upstream bug).  However you can just remove the file
> after 'make install', but not in %check.

I have done it already in the SPEC file present on dropbox as explained above.

> You have replaced the spec file on dropbox and not in the src.rpm file, please
> revert it as fedora-review parses this bug entry for downloading files.

My bad, I corrected it. While copying files between machines, I ended up with
wrong SPEC file there. Now, I have uploaded the right SPEC file, which was
used to generate the SRPM.

> Apart from this, building your last src.rpm file on a Fedora 18 x86_64 and a
> RHEL 6 x86_64 mock chroot does not include the font file; so it seems it's
> fine as it is; maybe it's just some confusion :)

I believe this is because I have 'rm docs/api/build/html/FreeSans.ttf' in
%check
section. You can see it in the SPEC file inside SRPM.

> This spec file does not even build a src.rpm as you used the %build, %check
> etc. tags in the comments; if you want to use those in the %changelog
> prepend them with another %; like %%build or %%check.

Yeah, it is because I uploaded the wrong SPEC file.

> Building on Fedora 19 x86_64 produces this error and the build fails:

I will try Fedora 19 build today.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l5bq5Y7xCD&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]