Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949214 --- Comment #5 from Lokesh Mandvekar <lsm5@xxxxxxxxxxx> --- Sorry about the delay. I learned a few more things since last time, thanks to spot. * Name and version shouldn't be hardcoded in URL and Source0 * in %install, you have used both $RPM_BUILD_ROOT and %{buildroot}. I think it's preferable to keep it consistent * the double blank lines between sections aren't needed. use single lines (as per what spot told me). Also, no need for a blank line between Summary and License. I guess these are all I can see for now, but I can revisit this as I pick stuff up -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=auX7ADjZeN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review