[Bug 852503] Review Request: perl-Net-Radius - Object-oriented Perl interface to RADIUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852503

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |psabata@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |psabata@xxxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #5 from Petr Šabata <psabata@xxxxxxxxxx> ---
(In reply to comment #4)
> Ok, I just did:
> https://github.com/inverse-inc/perl-Net-Radius.spec/commit/
> 813b472dfaa0981c0f32aff5da4d0b0f9a6aba2b
> 
> The reason I didn't do it is that I thought bumps / ChangeLog entries on
> unreleased packages undergoing a review would only add clutter and little
> value. Repoforge guys handled some of my contributions that way with that
> rationale and so I kept it. 
> 
> My plan was that once released, of course, release and changelog will be
> bumped on changes.
> 
> Sorry about my wrong assumptions.

I actually agree with you.

Bumping release doesn't really help anything; the reviewer should always check
the real diff from the previously submitted spec.  Tracking those in git is
ridiculously easy.

Still, there are many people in Fedora who prefer release bumps during
reviews...

Anyhow, it doesn't seem like Eduardo is going to work on this so I'll do the
review instead.  I'm also a sponsor so in case I like your packages, I'll take
you in :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mI1SDcNaRw&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]