Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928609 Karel Volný <kvolny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #8 from Karel Volný <kvolny@xxxxxxxxxx> --- to summarize: * bundled code - the file gl_texture_bind_test.py is based on gl-hello.py from toonplayer this is irrelevant, as it doesn't get packaged; if it would be included, the only issue with this would be to get the licensing correct - rencode - http://code.google.com/p/rencode/ hm, well, deluge seems to be using this too and it is not explicitly discussed in the review request (bug #221669) ... however, the deluge's version seems completely different, so it would be a big problem to share the code, so I would go for an exception here note that this adds GPLv3+ to licenses, and according to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Footnote3 I believe whole xpra would need to upgrade to GPLv3+ ...? - python-webm - http://code.google.com/p/python-webm/ I believe this is a good candidate for unbundling, but I'm not opposing another exception * rm -rf %{buildroot} we've dropped this long time ago ... I cannot find it anywhere as formal requirement not to have this, but I'd remove the line so the tool doesn't complain about that :-) * versioned dependency operator according to: http://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch-advanced-packaging.html#id709435 "==" is not valid operator, just "=" * large docs I'd suggest not to have three copies of NEWS ... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LYHZ4yllNr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review