Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=926968 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- First important question : do you really want to maintain this package which seems obviously dead upstream: ~9 year old version... [!]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: unzip See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Also use "%setup -q -c" instead of direct call to unzip [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Please add link to the request [!]: Packages should try to preserve timestamps of original installed files. use "install -p" or "cp -p" instead of cp [!]: SourceX is a working URL. Non-versioned URL, should switch to sourceforge which provides versioned URL. [!]: Rpmlint is run on all installed packages. Easy to fix: wrong-file-end-of-line-encoding -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iBsU8cfdRv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review