[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329

--- Comment #33 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to comment #31)
> (In reply to comment #27)
> > Because when it created it empty.
> 
> Then fix it. This is an arched package, so debuginfo files are mandatory.
> In other words something is defective and you (the prospective packager) are
> supposed to fix it.

This is the cause:
%install
pushd Project/GNU/Library
    make install-strip DESTDIR=%{buildroot}
popd
Invoke "make install" instead of "make install-strip".
(Background: executables must not be stripped for debuginfo generateion.
Rpm automatically strips them later.

Finally there are more questionable items in your spec:
* autogen is supposed to be run in %prep (not in %build)

* you are passing --disable-static to %configure
=> find %{buildroot} -name '*.a' -exec rm -f {} ';'
is superfluous.

* Many source files carry bogus permissions. chmod -x them in %
A visible symptom is rpmlint complaining about files in *debuginfo:
... 
libzen-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/ZenLib/Source/ZenLib/Format/Http/Http_Cookies.cpp
libzen-debuginfo.x86_64: E: wrong-script-end-of-line-encoding
/usr/src/debug/ZenLib/Source/ZenLib/Format/Http/Http_Cookies.cpp
libzen-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/ZenLib/Source/ZenLib/ZtringListListF.h
...

* Another MUSTFIX: 
libzen-devel.x86_64: E: script-without-shebang /usr/bin/libzen-config

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NXmi79YqQL&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]