Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #64 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #63) > (In reply to comment #61) > > I am a bit unsure if using GPL is valid as license, but I added it > > due to (http://www.wrongway.org/?rubiksource): > > ---%<--- > > The source code for my various rubik solvers are freely available. They are, > > for the moment, released GPL (e.g., free to distribute and modify but it and > > its derivitives must always remain free and open source). > > ---%<--- > > If no specific version of the GPL is specified, then the license tag should > contain "GPL+". See the entry for "GNU General Public License (no version)" > here: > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses. I changed to GPL+. > > This should not go in the final package. Just remind me, or > > yourself if you wish about ensuring those pretrans and posttrans > > are removed once the package is approved :-) > > I'm probably going to remind you very, very soon now, then, because I think > this package is ready. Fix the license tag as noted above and ... there > isn't anything else holding this package back, right? All of the bundled > stuff has been granted exceptions. I can't come up with anything else that > is blocking approval, but the package is so large and complex that I'll wait > a short time for comments before I approve it. Should I keep this chunk btw? Same issue as other review: ---%<--- %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : ---%<--- because the icon is actually installed under %{_datadir}/pixmaps, or should the icon be moved elsewhere (under %{_datadir}/pixmaps). Not uploading a new src.rpm because it takes at least one hour in my DSL (upload is very slow), but here is the spec diff for now: ---%<--- --- SPECS/sagemath.spec.orig 2013-04-14 15:36:46.068616049 -0300 +++ SPECS/sagemath.spec 2013-04-14 15:42:09.567628437 -0300 @@ -74,11 +74,11 @@ Group: Applications/Engineering Summary: A free open-source mathematics software system Version: 5.8 -Release: 2%{?dist} +Release: 3%{?dist} # The file ${SAGE_ROOT}/COPYING.txt is the upstream license breakdown file # Additionally, every $files section has a comment with the license name # before files with that license -License: ASL 2.0 and BSD and GPLv2+ and LGPLv2+ and MIT and Public Domain +License: ASL 2.0 and BSD and GPL+ and GPLv2+ and LGPLv2+ and MIT and Public Domain URL: http://www.sagemath.org %if %{download_tarball} Source0: http://boxen.math.washington.edu/home/%{name}/sage-mirror/src/sage-%{version}.tar @@ -1151,24 +1151,8 @@ %postun core -p /sbin/ldconfig -%pretrans data -# temporary due to moving directory to symlink when changing data to noarch -if [ -d %{SAGE_ROOT}/share -a ! -e %{SAGE_SHARE} ]; then - mv %{SAGE_ROOT}/share %{SAGE_SHARE} - ln -s %{SAGE_SHARE} %{SAGE_ROOT}/share -fi - -%pretrans doc -# temporary due to moving directory to symlink when changing data to noarch -if [ -d %{SAGE_ROOT}/devel/doc -a ! -e %{SAGE_DOC} ]; then - mv %{SAGE_ROOT}/devel/doc %{SAGE_DOC} - ln -s %{SAGE_DOC} %{SAGE_ROOT}/devel/doc -fi - -# Note this should be a plain %%post but make a %%posttrans for -# a small window of time to allow clean upgrades, as previously -# the (broken) links were added to the package. -%posttrans notebook +# Use symlinks and a minor patch to the notebook to not bundle jmol +%post notebook ln -sf %{_javadir}/JmolApplet.jar %{python_sitearch}/sagenb/data/jmol/ ln -sf %{_javadir}/vecmath.jar %{python_sitearch}/sagenb/data/jmol/ @@ -1255,7 +1239,7 @@ #------------------------------------------------------------------------ %files data-polytopes_db -# GPL +# GPL+ %{SAGE_SHARE}/reflexive_polytopes #------------------------------------------------------------------------ @@ -1374,12 +1358,12 @@ #------------------------------------------------------------------------ %files rubiks -# GPL +# GPL+ %{SAGE_LOCAL}/bin/optimal # MIT %{SAGE_LOCAL}/bin/dikcube %{SAGE_LOCAL}/bin/size222 -# GPL +# GPL+ %{SAGE_LOCAL}/bin/cu2 %{SAGE_LOCAL}/bin/cubex %{SAGE_LOCAL}/bin/mcube @@ -1393,6 +1377,10 @@ ######################################################################## %changelog +* Sun Apr 14 2013 pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> - 5.8-3 +- Use proper license tag for non versioned GPL attribution (#877651#63) +- Remove no longer required workarounds for clean upgrades (#877651#63) + * Fri Apr 12 2013 pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> - 5.8-2 - Properly describe the license breakdown in the spec (#877651#60) - Correct lrslib requires to lrslib-utils (#877651#60) ---%<--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z35gZv7bzp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review