Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914798 --- Comment #4 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #3) > Issues: > 1. The proper build flags are not being used. The proper *linker* flags are, > though. It was being hardcoded in src/CMakeLists.txt. Added a patch to revert it. > 2. Where did "WTFPL" for the main package license and "CC-BY-SA" for the data The WTFPL comes from the home page http://jvgs.sourceforge.net/ as well as the README in https://github.com/jaspervdj/jvgs But you are right, I did not full proof check it. It appears the license was changed after the last tarball upload to sourceforge. I changed to use the license in the tarball, and not the one in the main page neither in github sources. > package license come from? The "AUTHORS" file claims that the code and > data are GPL (no version specified), the graphics are CC0, the soundtrack > is Creative Commons Attribution Non-Commercial Share Alike (which cannot > be > used in Fedora: see > > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3), > and sound effects are the same license as Wesnoth (GPLv2+). I'm not > totally sure what is in each package, other than that the code is in the > main package. Can you explain the licensing situation, please? (Also, > are > the reused Wesnoth files packaged? If so, is there some way of reusing > the > existing Wesnoth packages?) I believe it may not be reasonable to use. Probaly would need to requires wesnoth and symlink .ogg files from wesnoth data dir, and still, the files are likely very small. Example: $ du -h BUILD/jvgs-0.5-src/resources/hedgehog/hedgehog.ogg 12K BUILD/jvgs-0.5-src/resources/hedgehog/hedgehog.ogg and there are like only 3 or 4 of those. > 3. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > for scriptlets to use with a desktop file that installs an icon. It is not under %_datadir/icons but in %_datadir/pixmaps. I have at least one other package that installs an icon in %_datadir/pixmaps. Should I move the icon to %_datadir/icons and add the scriptlets? > 4. According to > > https://fedoraproject.org/wiki/Packaging: > Guidelines#Avoid_bundling_of_fonts_in_other_packages > you should not bundle the one font file into the -data subpackage. > However, > this is only a *should*, not a *must*, and I'm not at all convinced that > you > should change the package. I will try to confirm what I believe to be the case, but I think this is a specially edited/built font just for the game, to have the hand written effect. > 5. The man page is installed into man6, but it says (1) on the actual page. Ops. Fixed. I made a new package for the sake of correcting what I could, but I will email the author to try to clarify the license issues. Update: - Use license information from tarball not homepaga (#914798#3). - Do not hardcode CMAKE_CXX_FLAGS (#914798#3). - Correct manual page section (#914798#3). Spec URL: http://pcpa.fedorapeople.org/jvgs.spec SRPM URL: http://pcpa.fedorapeople.org/jvgs-0.5-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NGwbC14FEA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review