[Bug 894585] Review Request: coin-or-CoinUtils - Coin-or Utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894585

--- Comment #4 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> ---
(In reply to comment #3)

  Jerry, I have been talking with upstream since around september last
year, and was in search of someone to review the packages since early
this year :-) Maybe now it can be done, but at first I only need a
few of them reviewed (5 actually, including CoinUtils), to enable Cbc
in sagemath.
  After significant talk from time to time, upstream made a new,
non official (yet), directory for distribution at:

http://www.coin-or.org/download/pkgsource/

that unlike the tarballs at:

http://www.coin-or.org/download/source/

have the dependencies stripped from the tarball, that is no need
for the %{with_bundle} macro, and also have ThirdParty directories
removed.

> Issues, in no particular order:
> 1. The documentation is quite large.  This can be remedied by NOT listing
>    graphviz as a BR.  Then dot won't generate the big class diagrams.  I've
>    had to do this for several of my packages, as the interaction diagrams
> grow
>    quite large.

  Is it ok to just split out a -doc package? Most users should get it
only as build requires or requires. Either way, I did both, split -doc
and remove graphviz from build requires.

> 2. Version 2.9.0 came out 2 days ago.  (I checked because of the "latest
>    version is packaged" question below.)
> 3. The undefined non-weak symbols reported below indicate that the library
>    needs to be linked with -lz -lbz2.

  Add patch to correct the problem.

> 4. The BRs list both atlas-devel, and also blas-devel and lapack-devel. 
> Since
>    atlas is a replacement for the standard blas and lapack, I'm confused.
>    Which one are you trying to use?  Also, the final requires don't show
>    either, so are any of them really needed at all?

  They are not really required. But configure still checks for them.
It should have been left from my first test packaging of coin-or,
when it did build all bundled dependencies, as this is one of the
first ones to be built. I just removed all blas* build requires.


Update:

- Update to latest upstream release.
- Switch to the new upstream tarballs without bundled dependencies.
- Split documentation in a new subpackage (#894585#3)
- Correct undefined non weak symbols (#894585#3)
- Removed unneeded atlas, blas, glpk and lapack build requires (#894585#3)

Spec URL: http://pcpa.fedorapeople.org/coin-or/coin-or-CoinUtils.spec
SRPM URL:
http://pcpa.fedorapeople.org/coin-or/coin-or-CoinUtils-2.9.0-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AHFiDNWEFZ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]