Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951777 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pingou@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |pingou@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- Looking at the README and the header of the source the appropriate license tag appears to be LGPLv3+, maybe upstream would want to precise this in the setup.py I am surprised by the difference between the list of BuildRequires and Requires. Are all the additionnal libraries in BR really only required for the tests? Otherwise: * package meets naming guidelines * package meets packaging guidelines * spec is clean * license LGPLv3+ is fine (license tag needs to be adjusted) * source matches upstream: 89269d33251cdc70543469421f8969a8fc284337 * no missing BR * no unnecessary BR * no locales * not relocatable * owns all directories that it creates * no duplicate files * permissions ok * macro use consistent * code, not content * no need for -docs * nothing in %doc affects runtime * no need for .desktop file I'll need to test how it compiles with python-cairosvg -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b4EFFVACej&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review