Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 greg.hellings@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from greg.hellings@xxxxxxxxx --- Your Spec file URL above doesn't work for me, so I just went off the one in the .src.rpm file $ rpmlint mingw-qt5-qtquick1.spec mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{snapshot_rev} 0 packages and 1 specfiles checked; 0 errors, 4 warnings. $ rpmlint mingw-qt5-qtquick1-5.0.1-1.fc19.src.rpm mingw-qt5-qtquick1.src: E: unknown-key GPG#9b393ae8 mingw-qt5-qtquick1.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtquick1.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.src:26: W: macro-in-comment %{snapshot_rev} 1 packages and 0 specfiles checked; 1 errors, 4 warnings. $ rpmlint results_mingw-qt5-qtquick1/5.0.1/1.fc18/mingw{32,64}* mingw32-qt5-qtquick1.noarch: W: no-documentation mingw32-qt5-qtquick1-debuginfo.noarch: E: debuginfo-without-sources mingw64-qt5-qtquick1.noarch: W: no-documentation mingw64-qt5-qtquick1-debuginfo.noarch: E: debuginfo-without-sources 4 packages and 0 specfiles checked; 2 errors, 2 warnings. $ rpm -q --requires mingw32-qt5-qtquick1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 83 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libglesv2.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt5core.dll) mingw32(qt5declarative.dll) mingw32(qt5gui.dll) mingw32(qt5network.dll) mingw32(qt5opengl.dll) mingw32(qt5script.dll) mingw32(qt5sql.dll) mingw32(qt5widgets.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --requires mingw64-qt5-qtquick1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 83 mingw64(kernel32.dll) mingw64(libglesv2.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt5core.dll) mingw64(qt5declarative.dll) mingw64(qt5gui.dll) mingw64(qt5network.dll) mingw64(qt5opengl.dll) mingw64(qt5script.dll) mingw64(qt5sql.dll) mingw64(qt5widgets.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --provides mingw32-qt5-qtquick1 mingw32-qt5-qtquick1 = 5.0.1-1.fc18 mingw32(qt5declarative.dll) mingw32(qmldbg_inspector.dll) mingw32(qmldbg_tcp_qtdeclarative.dll) mingw32(qmlfolderlistmodelplugin.dll) mingw32(qmlgesturesplugin.dll) mingw32(qmlparticlesplugin.dll) mingw32(qmlshadersplugin.dll) $ rpm -q --provides mingw64-qt5-qtquick1 mingw64-qt5-qtquick1 = 5.0.1-1.fc18 mingw64(qt5declarative.dll) mingw64(qmldbg_inspector.dll) mingw64(qmldbg_tcp_qtdeclarative.dll) mingw64(qmlfolderlistmodelplugin.dll) mingw64(qmlgesturesplugin.dll) mingw64(qmlparticlesplugin.dll) mingw64(qmlshadersplugin.dll) + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4 or %mingw_qmake_qt5 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [+] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal All of the warnings and the dependency difference have been addressed in other qt5 reviews. Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pV0gDm6vCL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review