Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856 --- Comment #8 from Lokesh Mandvekar <lsm5@xxxxxxxxxxx> --- Spot, I overlooked quite a few things in the previous version. Should be fixed now. Please take a look: Spec URL: https://github.com/lsm5/rpmbuild/blob/master/SPECS/spectrwm.spec SRPM URL: https://github.com/lsm5/rpmbuild/blob/master/SRPMS/spectrwm-2.2.0-2.fc20.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5244867 $ rpmlint SRPMS/spectrwm-2.2.0-3.fc20.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/x86_64/spectrwm-2.2.0-3.fc20.x86_64.rpm spectrwm.x86_64: E: invalid-soname /usr/lib64/libswmhack.so.0.0 swm_hack.so 1 packages and 0 specfiles checked; 1 errors, 0 warnings. $ rpmlint RPMS/x86_64/spectrwm-devel-2.2.0-3.fc20.x86_64.rpm spectrwm-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint SPECS/spectrwm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Could you checkout the patch for -Wl,-soname and let me know if I'm doing it right? https://github.com/lsm5/rpmbuild/blob/master/SOURCES/spectrwm-2.2.0-versioned-shared-lib.patch Also, I'm not sure what to include in spectrwm-devel documentation. Is it ok to leave it blank? spectrwm now includes man pages in documentation. The .h files used by the lib file get installed via the dependencies itself. The only .h file in spectrwm itself is version.h which doesn't look to be installed on other distros, so I'm guessing it isn't really needed. Let me know if there's something I'm missing here. The upstream Makefile doesn't worry about the spectrwm.desktop file. Looks like they leave it to the user to take care of it (asked this on their IRC too, and nobody cared much about this file). I'm able to use spectrwm without it, so I think it's safe to ignore it (unless another user would want it). Thanks, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7BCoFbW3xN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review