Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928609 --- Comment #5 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Thanks for the review! (In reply to comment #4) > a few complaints from the fedora-review tool: > > - install fails because of dependency on gstreamer-plugins-ugly, this > belongs to the rpmfusion part > - gtk-update-icon-cache and update-desktop-database not called in post > scripts I fixed both of these. > in addition, it reports more rpmlint problems not discussed above - strange > permissions: <snip list> > I believe these should be 755 I'm not sure why rpmlint doesn't complain about these on my machine, but I nonetheless ensured chmod was run on these files in the spec. > also the list corresponds to the list of unversioned libraries: <snip list> > > I believe this fits under the exception mentioned in > https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages <snip quote> > > ... right? Yes. These unversioned shared objects are C extensions to the Python interpreter, so thus fit the spirit and letter of the quoted exception. -- Spec: http://patches.fedorapeople.org/xpra/xpra.spec SRPM: http://patches.fedorapeople.org/xpra/xpra-0.8.8-3.fc18.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5243685 * Thu Apr 11 2013 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 0.8.8-3 - drop unmet dependency on gstreamer-plugins-ugly - fix permissions on shared objects - add scriptlets necessary for icon/desktop file -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JaRGG5glgV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review