Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951250 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- == REVIEW == Good: - rpmlint checks return: R-sandwich.src:45: W: macro-in-comment %check R-sandwich.src:46: W: macro-in-comment %{_bindir} R-sandwich.src:46: W: macro-in-comment %{packname} All safe to ignore (but feel free to %% them to make these warnings go away) - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK - spec file legible, in am. english - source matches upstream 0a99d0c4b1fbb25655cb26c65358a9f9055bccd1b398cb5b0813810b961df69b - package compiles on f18 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3dIbo7xoxy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review