Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #43 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- > But %cmake macro has no debug or release flags at all. Most projects don't actually need a build type. While in principle, a CMakeLists.txt can do all sorts of things depending on the build type, the only thing the build type is typically used for on *nix is to add some additional compiler flags (and sometimes linker flags, but by default, the added linker flags are empty). So in most cases (I have not looked closely at this particular project though!), setting CMAKE_BUILD_TYPE=Release just to set CMAKE_CXX_FLAGS_RELEASE to "" or to "-O2" (which is already in the RPM_OPT_FLAGS) does nothing at all. Also note that the default flags for Release also contain -DNDEBUG and that is usually the main difference between Release and Debug builds, so if you want a true release build, you should set CMAKE_CXX_FLAGS_RELEASE to "-O2 -DNDEBUG" or just "-DNDEBUG", not to just "-O2". > And what about -O3? -O3 should not be in the resulting build flags, that's the main thing to ensure. How to do it is up to you. My point is only that the 2 flags you are adding are probably not necessary. But they are not wrong, just probably not needed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VnjEOAPpP9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review