Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909644 --- Comment #8 from Patrick Uiterwijk <puiterwijk@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License LGPLv2 OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 14010ab0f301ef2870079257611742d4 websocket-client-0.9.0.tar.gz 14010ab0f301ef2870079257611742d4 websocket-client-0.9.0.tar.gz OK - BuildRequires correct NO, See below - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag NO, See below - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: Checking: python-websocket-client-0.9.0-2.fc18.noarch.rpm python-websocket-client.noarch: W: spelling-error %description -l en_US hybi -> hybrid python-websocket-client.noarch: E: incorrect-fsf-address /usr/share/doc/python-websocket-client-0.9.0/LICENSE python-websocket-client.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/websocket_client-0.9.0-py2.7.egg-info/dependency_links.txt python-websocket-client.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/websocket_client-0.9.0-py2.7.egg-info/top_level.txt python-websocket-client.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/websocket_client-0.9.0-py2.7.egg-info/PKG-INFO python-websocket-client.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/websocket_client-0.9.0-py2.7.egg-info/SOURCES.txt python-websocket-client.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/websocket.py python-websocket-client.noarch: W: no-manual-page-for-binary wsdump 1 packages and 0 specfiles checked; 6 errors, 2 warnings. As indicated by rpmlint, the +x should be removed from the egg-info files. 2. Version 0.10.0 has been released in the mean time: https://pypi.python.org/pypi/websocket-client/0.10.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I1XuDzdr5k&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review