Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request - jwm - Very light window manager Alias: jwm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230738 aportal@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aportal@xxxxxxxxxxxxxx ------- Additional Comments From aportal@xxxxxxxxxxxxxx 2007-03-04 10:45 EST ------- Sorry, I can't sponsor you. This isn't a full review, I just found some thing you have to fix. BuildRequires: libX11 isn't needed jwm doesn't honor $RPM_OPT_FLAGS, which means it's built without any compiler provided security features and other distro wide CFLAGS. Also, the debuginfo package is useless because the binary is explicitly stripped. One way to fix these issues is to add these after %configure: sed -i -e 's/^\(CFLAGS.*\)/\1 $(RPM_OPT_FLAGS)/' src/Makefile sed -i -e '/^\s*strip /d' src/Makefile -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review