Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #15 from Nikita Klimov <nk@xxxxxxx> --- Unfortunately, there are a number of comments: - In License: section replace 'zlib/libpng License' to 'zlib/libpng' - dos2unix *.txt Source/Doc/*.html -> dos2unix *.txt Source/Doc/Documentation.html (wildcard in my opinion not need) - Please don't ignore any remark: "Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable. " https://fedoraproject.org/wiki/Packaging:Guidelines#Macros For example: %__chmod -> chmod If you disagree with any remark, explain your point of view, but don't ignore it. - Doxygen's tags 'DETAILS_AT_TOP' and 'HTML_ALIGN_MEMBERS' has become obsolete, please contact upstream. Temporary you can use: doxygen -u before generate documentation. - Do more informative comments in %{changelog} section. For example 'Clean spec' and 'Spec prepared for review' not informative. "This is important not only to have an idea about the history of a package, but also to enable users, fellow packages, and QA people to easily spot the changes that you make." http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - Please add short informative comments to %{prep}, %{build} and %{install} section before any 'nonstandart' tasks, that explains why this task necessary. - I know that you are also maintainer in RFRemix project, but in this stage it doesn't matter. We have to prepare the package for inclusion in Fedora, not RFRemix. And so the package must comply with Fedora rules. Please remove RFRemix tags in %{changelog} section. - Do you read this https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Convincing_someone_to_sponsor_you ? Please try to doing informal reviews to other packagers in order to find and convincing a willing sponsor. I can help fix errors and omissions in package, but can't be a sponsor, and so can't do formal review, because review and approval for the first package for new packagers must be done by registered sponsors. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6RoSwWxRGi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review