Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grass - GRASS (Geographic Resources Analysis Support System) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227646 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-03-04 05:35 EST ------- Created an attachment (id=149205) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149205&action=view) rpmlint log of grass-6.2.1-9 with two BR added Well, for -9: * BuildRequires: - As said before, "libtiff-devel libpng-devel" are missing at least. - Please check the following. ------------------------------------------------------ checking for mysql_config... /usr/bin/mysql_config checking for mysql_server_init... no configure: warning: libmysqld not found ------------------------------------------------------ * Requires (expecially for -devel) package - Check the Requirement for -devel package. @ Usually this can be checked by what files the header files in -devel package try to "include". @ And usually these dependencies should correcly appear on pkgconfig .pc file as "Requires:" section @ And the requirement for pkgconfig is missing * Source - Please specify URLs of all sources (if possible), especially Source2. * Timestamps - This package contains a lot of text files (such as header files, scripts), image files and so. Please keep timestamps on those files. * rpmlint (check attached) + incoherent-version-in-changelog (This is because I increased the release number to add missing BuildRequires) - unused-direct-shlib-dependency This can be usually ignored. - undefined-non-weak-symbol @ As this has -devel package and linkage is done for the libraries in -devel package, this cannot be ignored. Perhaps linkage against libm.so is missing. * Compiler flags - Well, would you explain a bit more in detail what happens with "-Wp,-D_FORTIFY_SOURCE=2" (on this bug)? And is it not-so-easy problem to fix? * Desktop file - Category "Application" is deprecated and should be removed. * Documentation total size - Well, I wonder if -doc subpackage should be created for grass because the documentation included in main packages seems a bit large in total.. * Documentation - I think the following documentations should be added ---------------------------------------------------------- CHANGES - to main ChangeLog_6.2.1.gz - to -devel TODO - to devel ----------------------------------------------------------- * License - Well, just a question, what are the following files? ---------------------------------------------------------- ./lib/gis/datum.table ./lib/gis/datumtransform.table ---------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review