Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #21 from Ravindra Kumar <ravindrakumar@xxxxxxxxxx> --- (In reply to comment #17) > I agree that the guestd daemon should be started upon installation as this > is installed only in VMWare guests. Yes. > After the review I will file a ticket to FESCO as required, to see if we can > enable it: > > https://fedorahosted.org/fesco/ > > So for now _all_ services should be installed but disabled by default. Sure. Could you please CC me on the ticket? > 2) Systemd conditionals > > To enable Systemd for Fedora 17 and 18+, we need to apply the packaging > policies as defined here: > > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd > > As you see, there are differences between those 2 blocks (18+ and 17) so an > "%if" between distributions should be applied > When f17 will be EOL, the block relevant to it can be removed. > > 3) RHEL/CentOS 5 building > > RHEL/CentOS 5 has rpm 4.5 and needs some more settings for packages. ... > > 4) SysV init script conditionals > > SysV init scripts for RHEL/CentOS systems is defined in these policies: > > https://fedoraproject.org/wiki/Packaging:SysVInitScript > > Again we need to "%if" the distribution from Fedora. Thanks for making all the changes and providing the patch. Given all these complexities and testing effort, I'm inclined to focus on Fedora 18+ and RHEL 7+, because those are almost the same from systemd perspective. That will help me keep the SPEC file simple and testing is easy for me. Hope you would agree with me? > 5) open-vm-tools-desktop > > The file "/etc/xdg/autostart/vmware-user.desktop" contains a note about KDE, > can you check that this is still valid? I looked at the bug https://bugs.kde.org/show_bug.cgi?id=190522 and it seems to have been fixed in a way that it is not reproducible. However, I will not be able to fix/test the note right now, because this file is coming from open-vm-tools source and we will need to fix the source code as sourceforge. I think we will need to raise a ticket for open-vm-tools code. > 6) open-vm-tools-guestd.service > > Please see the following URL: > > http://fedoraproject.org/wiki/Packaging:Systemd > > - The Documentation directive is missing I don't see any man pages generated from open-vm-tools build, so I have just added a link to http://open-vm-tools.sourceforge.net/about.php. > - The lines "RestartSec=5" and "TimeoutStopSec=2" are probably not needed, > as the process is contained in a cgroup Removed RestartSec. TimeoutStopSec default is 90s which is way too long from service stop and guest shutdown perspectives. Please note that tools service does not handle SIGTERM nicely, so systemd ends up timing out and issues SIGKILL ultimately to kill this service. I believe this also needs to be fixed in open-vm-tools source code. > - Daemons should not be forking if possible, they should "stay" in the > foreground as systemd takes care of that. Can the "Type=forking" line be > removed? I had started with "simple" service and had some issues. So, I set it to forking, I will try again with "simple". > - Probably you can make the description like "Service for virtual machines > hosted on VMware" and remove the package name from it, but this is not > required. Changed. I will share the updated the SPEC file and SRPM in a few minutes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ehjKQJV9Wa&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review