Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949073 Gianluca Sforna <giallu@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #7 from Gianluca Sforna <giallu@xxxxxxxxx> --- ==== REVIEW CHECKLIST ==== - package named according to package naming guidelines - package licensed with allowed license - license matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream sha256sum - successfully builds in mock for rawhide x86_64 - no locales - no shared libraries - package owns all directories it creates - macro usage is consistent - package contains code - large documentation moved to subpackage - not a GUI app needing a .desktop file - rpmlint has to say: rpmlint /var/lib/mock/fedora-18-x86_64/result/*.rpm check-mk.src: W: spelling-error %description -l en_US snmp -> snip, snap, sump check-mk.src:151: E: hardcoded-library-path in %{_prefix}/lib/check_mk/livecheck check-mk.src:152: E: hardcoded-library-path in %{_prefix}/lib/check_mk/livestatus.o check-mk.src:153: E: hardcoded-library-path in %{_prefix}/lib/check_mk check-mk.src:197: E: hardcoded-library-path in %{_prefix}/lib/check_mk check-mk.x86_64: W: spelling-error %description -l en_US snmp -> snip, snap, sump check-mk.x86_64: E: no-binary check-mk.x86_64: W: non-conffile-in-etc /etc/check_mk/conf.d/README check-mk.x86_64: W: non-conffile-in-etc /etc/check_mk/First-Installation.txt check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/counters nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/counters nagios check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/autochecks nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/autochecks nagios check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/wato nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/wato nagios check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/logwatch nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/logwatch nagios check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/precompiled nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/precompiled nagios check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/web nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/web nagios check-mk.x86_64: E: incorrect-fsf-address /usr/share/doc/check-mk-1.2.2/COPYING check-mk.x86_64: W: non-standard-uid /var/lib/check_mk/cache nagios check-mk.x86_64: W: non-standard-gid /var/lib/check_mk/cache nagios check-mk.x86_64: W: no-manual-page-for-binary check_mk check-mk.x86_64: W: no-manual-page-for-binary cmk check-mk.x86_64: W: no-manual-page-for-binary mkp check-mk-agent.x86_64: E: incorrect-fsf-address /usr/share/doc/check-mk-agent-1.2.2/COPYING check-mk-agent.x86_64: W: no-manual-page-for-binary check-mk-agent check-mk-docs.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/check_mk/agents/README.OpenVMS check-mk-docs.noarch: W: file-not-utf8 /usr/share/doc/check_mk/treasures/fsc-celsius-m470-sel-1.2.tar.gz check-mk-docs.noarch: E: incorrect-fsf-address /usr/share/doc/check_mk/COPYING check-mk-docs.noarch: W: class-path-in-manifest /usr/share/doc/check_mk/jasperreports/libs/com-jaspersoft-ireport.jar check-mk-livestatus.x86_64: W: no-documentation check-mk-livestatus.x86_64: W: no-manual-page-for-binary unixcat check-mk-multisite.noarch: W: no-documentation 7 packages and 0 specfiles checked; 8 errors, 28 warnings. that I consider harmless. Feel free to tell upstream about the license text address issue and maybe check if it is correct it's still shipping a .tar.gz file No other blockers spotted so this package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hwtn9LHd4B&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review