[Bug 929256] Review Request: nomacs - Qt-based image viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256

--- Comment #32 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
> 1. "-DCMAKE_BUILD_TYPE=Release" - as you know - %cmake by default not set
> Release.

But my point is, why do you want to set the build type to Release at all? All
it typically does is set some flags, and in this case you don't want either of
the 2 flags it sets (we definitely don't want -O3, and you also removed the
-DNDEBUG).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wMu1jqtrlo&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]