Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #12 from Simone Caronni <negativo17@xxxxxxxxx> --- 1) Please use tabs or spaces consistently in the SPEC file; use tabs all over or spaces. For example, all the "Group" lines use spaces and not tabs like the rest of the file. 2) Please reduce the number of variables at the beginning of the SPEC file, for example there's no reason for "toolspkgname" to exist, you could already use "%{name}" where required. 3) Please add a %doc directive to the base package, there are at least the files: %doc AUTHORS ChangeLog COPYING INSTALL NEWS README that can be added to the release. According to the packaging guidelines, you should have at least the license file installed in any combination of the packages/subpackages, so that is required at least in the base package. 4) File ownership... The base package should own the %{_sysconfdir}/vmware-tools/ directory entirely and not only the files therein. The same goes for the directory %{_libdir}/%{name}/; is not currently owned by any package. There's a floating alone "%doc" line at the end of the file before the %changelog section, probably is there by mistake. 5) The Group "Application/Documentation" is not valid, please use "Documentation". 6) There's a check command that can be performed in the build, so please add a section before %post: %check make check 7) During a review, the %changelog should be upgraded and updated as you did for the comment part but also the revision number should change. 8) The install command should preserve timestamps (-p) and the systemd service files need not to be executable. 9) There's currently a subpackage defined as "help" but nobody is creating the specified folder listed in the files section and nobody is installing any document in it, so please: - Add a Build requirement for Doxygen. - Build the docs under the "help" directory, there's a Makefile. According to the configure script, all the documents should be built if doxygen is installed. - If they are very large, you can add them into a doc subpackage as it is now; but only by marking them in the %doc section. - If they are not, add them to the appropriate package as %doc lines. It appears they are quite big (~130kb); so a separate package is fine. 10) Please sort BuildRequires for easier reading. 11) The following directories should be owned by the base package, not only the files contained therein: %{_libdir}/%{name}/ %{_libdir}/%{name}/plugins %{_libdir}/%{name}/plugins/common/ %{_libdir}/%{name}/plugins/vmsvc/ This one should be owned by the desktop subpackage: %{_libdir}/%{name}/plugins/vmusr/ 12) The static archives (*.la) and unversioned shared objects (*.so) should be included in the devel subpackage. I think the static archives could be removed entirely. 13) The directory /sbin/ should be excluded entirely, not just its contents. 14) It's good practice that the description of packages/subpackages stay the closest to 80 columns (no more) after macros have been expanded. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yXvMhRJpfK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review