Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Thanks for the review. > - Package contains BR: python2-devel or python3-devel > See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires > Used python2-devel. > - Package own directory that belong to gnuradio ( > /usr/share/gnuradio/grc/blocks ) > Fixed. > - %{_isa} is missing in Requires from -devel > Fixed. > - why are some includes removed ( ie, the one about swig ) ? > Fixed. > - I would add the 2 examples application in %doc ( in apps/ ), what do you > think about it ? > Added to examples subdir. > - there is also some doxygen documentation, shouldn't it be shipped ? > Built. I also changed the group to Applications/Engineering. I sent all patches to upstream (osmocom-sdr@xxxxxxxxxxxxxxxxx), but the list seems moderated and my posts still didn't appear in the list archive. Spec URL: http://fedorapeople.org/~jskarvad/gr-osmosdr/gr-osmosdr.spec SRPM URL: http://fedorapeople.org/~jskarvad/gr-osmosdr/gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xv2lXDLlKk&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review