Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #11 from Nikita Klimov <nk@xxxxxxx> --- - "Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable. " https://fedoraproject.org/wiki/Packaging:Guidelines#Macros - Use %{buildroot} and %{optflags} or $RPM_BUILD_ROOT and $RPM_OPT_FLAGS but not %{buildroot} and $RPM_OPT_FLAGS or $RPM_BUILD_ROOT and %{optflags} https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS In my opinion %{buildroot} and %{optflags} a little more beautiful but ypu can use $RPM_BUILD_ROOT and $RPM_OPT_FLAGS if you prefer it. - Take a look at line 63 in spec file: 63 %__chmod +x autogen There is no need, since executable bit also set. - Take a look at line 64: 64 ./autogen There is also no need, simply use autoconf. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yojgqzHWo1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review