[Bug 947640] Review Request: snappy - An open-source Gnome media player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #4 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to comment #2)
> Hi, a few comment :

Hi Michael.

> - Requires:      
> gstreamer1,clutter,clutter-gtk,gstreamer1-plugins-base,clutter-gst,gtk3
> 
> gtk3, gstreamer1 and clutter are likely already pulled by rpm automated
> library dependency. And gstreamer1-plugins-base is likely pulled already.
> Can you clean the Requires from redundant rpm ?

Yes.

> 
> - why is autoreconf -i run in %build ?

'configure' file is not in main source directory. Indeed autoreconf command
seems not well-accepted in Fedora according to this old wiki
http://fedoraproject.org/wiki/PackagingDrafts/AutoConf. Currently I don't know
if it can be used safely in case like that.

Also, I could use 'autogen.sh' in the source but, in this way, 'configure'
would be additional.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TwLdaBNY46&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]