Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 --- Comment #4 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to comment #2) Thanks for the review. > - License is wrong, since there is a bundle of getopt > > - there is getopt in bundle It seems to be used only on win32, we would probably need to change the license field to GPL, thus removed in %pre and the license should be OK now. > > - -devel should pull main with %{_isa} > fixed > - patch being sent upstream should be documented in spec > fixed > - install should use -p ( if I am not wrong ), but that's minor > fixed Spec URL: http://fedorapeople.org/~jskarvad/rtl-sdr/rtl-sdr.spec SRPM URL: http://fedorapeople.org/~jskarvad/rtl-sdr/rtl-sdr-0-0.2.20130403git4a068f56.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HyERQXqpLu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review