Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866 --- Comment #24 from Peter Robinson <pbrobinson@xxxxxxxxx> --- There's a few minor bits to be cleaned up but we're mostly there. ? rpmlint output: The output below is mostly OK, there's a few things like spaces vs tabs need cleanup. rpmlint vboot-utils.spec ../SRPMS/vboot-utils-20130222gite6cf2c2-2.fc18.src.rpm vboot-utils.spec:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 1) vboot-utils.spec: W: invalid-url Source0: vboot-utils-20130222gite6cf2c2.tar.xz vboot-utils.src: W: spelling-error %description -l en_US chromebook -> chrome book, chrome-book, chromosome vboot-utils.src: W: spelling-error %description -l en_US gpt -> got, gt, pt vboot-utils.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 1) vboot-utils.src: W: invalid-url Source0: vboot-utils-20130222gite6cf2c2.tar.xz 1 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint vboot-utils-20130222gite6cf2c2-2.fc20.x86_64.rpm vboot-utils.x86_64: W: spelling-error %description -l en_US chromebook -> chrome book, chrome-book, chromosome vboot-utils.x86_64: W: spelling-error %description -l en_US gpt -> got, gt, pt vboot-utils.x86_64: W: no-manual-page-for-binary dump_kernel_config vboot-utils.x86_64: W: no-manual-page-for-binary dev_make_keypair vboot-utils.x86_64: W: no-manual-page-for-binary dev_debug_vboot vboot-utils.x86_64: W: no-manual-page-for-binary bmpblk_font vboot-utils.x86_64: W: no-manual-page-for-binary bmpblk_utility vboot-utils.x86_64: W: no-manual-page-for-binary tpmc vboot-utils.x86_64: W: no-manual-page-for-binary tpm_init_temp_fix vboot-utils.x86_64: W: no-manual-page-for-binary enable_dev_usb_boot vboot-utils.x86_64: W: no-manual-page-for-binary dumpRSAPublicKey vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_kernel vboot-utils.x86_64: W: no-manual-page-for-binary futility vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_firmware vboot-utils.x86_64: W: no-manual-page-for-binary eficompress vboot-utils.x86_64: W: no-manual-page-for-binary pad_digest_utility vboot-utils.x86_64: W: no-manual-page-for-binary signature_digest_utility vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_keyblock vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_key vboot-utils.x86_64: W: no-manual-page-for-binary efidecompress vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_what_keys vboot-utils.x86_64: W: no-manual-page-for-binary dev_sign_file vboot-utils.x86_64: W: no-manual-page-for-binary dump_fmap vboot-utils.x86_64: W: no-manual-page-for-binary gbb_utility vboot-utils.x86_64: W: no-manual-page-for-binary load_kernel_test vboot-utils.x86_64: W: no-manual-page-for-binary verify_data vboot-utils.x86_64: W: no-manual-page-for-binary crossystem vboot-utils.x86_64: W: no-manual-page-for-binary cgpt 1 packages and 0 specfiles checked; 0 errors, 28 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible ? upstream sources match sources in the srpm + package successfully builds on at least one architecture tested using koji scratch build on both x86 and ARM + BuildRequires list all build dependencies There's a few redundent extras n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install Permissions on files must be set properly + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files. It would nice to have some more docs but not a blocker -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dr4C6bPpSM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review