Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #6 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Some notes: * description - Some part of description is redundant and better to fix - "free" image viewer is just redundant. Fedora does not allow non-free software. - "for windows and Linux systems" is not needed - License information is shown in License column, writing also in description is just redundant. * SourceURL: - For sourceforge based tarball, please follow: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Sourceforge.net * Compilar flags - Optimization level -O2 in %optflags are replaced by -O3, which is discouraged on Fedora: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags ---------------------------------------------------------- 227 Building CXX object CMakeFiles/nomacs.dir/src/DkConnection.cpp.o 228 /usr/bin/c++ -DHAVE_EXIV2_HPP -DLIBRAW_VERSION_14 -DNOMACS_VERSION=\"1.0.0\" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_DEBUG_OUTPUT -DWITH_OPENCV -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -O3 -DNDEBUG -I/usr/include/QtGui -I/usr/include/QtNetwork -I/usr/include/QtCore -I/usr/include/QtDesigner -I/usr/include/QtDeclarative -I/usr/include/QtScriptTools -I/usr/include/QtDBus -I/usr/include/QtXml -I/usr/include/QtSql -I/usr/include/QtOpenGL -I/usr/include/QtMultimedia -I/usr/include/QtXmlPatterns -I/usr/include/QtHelp -I/usr/include/QtUiTools -I/usr/include/QtTest -I/usr/include/QtScript -I/usr/include/QtSvg -I/usr/include/Qt3Support -I/usr/lib/qt4/mkspecs/default -I/usr/include/libraw -I/usr/include/opencv -I/builddir/build/BUILD/nomacs-1.0.0/build -I/builddir/build/BUILD/nomacs-1.0.0/src -o CMakeFiles/nomacs.dir/src/DkConnection.cpp.o -c /builddir/build/BUILD/nomacs-1.0.0/src/DkConnection.cpp ---------------------------------------------------------- Please remove -O3 optimization level. * Updating mime infomation - Installed desktop file contains mime information. Please follow https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EWCGXF5aTS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review