[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #6 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> ---
(In reply to comment #5)
> IMHO, the spacing between sections is fine as is, it's definitely not a
> review criterion. I'd remove the blank lines INSIDE the %prep, %install and
> %files sections though, then the blank lines between the sections become
> better demarcators. IMHO, the sections are not so large that they need
> cutting into chunks with blank lines. But again, the specfile is legible as
> is, so this is mostly a matter of personal taste.

I agree that spec format is not blocker for review.
But some kind of readability must be.
As for me - I separate sections with one CR and no one blank CR inside
sections.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FNmEFzE7iW&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]