Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: nhpf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226199 ------- Additional Comments From ville.skytta@xxxxxx 2007-03-03 07:27 EST ------- Built without $RPM_OPT_FLAGS. One way to fix it is 'make CFLAG="$RPM_OPT_FLAGS"' instead of 'make' in %build (note CFLAG, not CFLAGS). URL points to a "this page has moved" page, and where it's moved to doesn't look too useful. Any better one available? "Distributable" as a license is frowned upon, but I'm not sure what else to put there in this case. nhpf.c does contain the license text, it looks pretty much like BSD but isn't quite the same. Perhaps it's close enough to use "BSDish" instead of "Distributable". Anyway, it'd be nice to have the license text available in the binary packages. I'm not able to log into the Source0 FTP server to verify sources nor do I actually have much clue at all what this package is about so I'll leave rest of the review to someone else. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review