Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: viewvc- Browser interface for CVS and SVN version control repositories https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230512 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-03-03 06:04 EST ------- > In relation to benchmarks, I'll have to set up mod_fcgi/viewvc combo here, > so it may take some time. I'll keep you posted. No problem, we want it to be a quality package, so take as much time as you need. Suggestions: 1) In your %post and %postun section, use full pathnames of the programs you run (ie. semanage & restorecon) 2) Use -b with patch to create a backup file. This is recommended by other fedora packages. Question: You have: # Set mode 755 on executable scripts %{__grep} -rl '^#!' %{buildroot}%{python_sitelib}/viewvc | xargs %{__chmod} 0755 but then later: # mod_python files do not have to be executable (make rpmlint happy) %{__chmod} 0644 %{buildroot}%{python_sitelib}/viewvc/bin/mod_python/*.py So, do any of the file need to be +x ?? Nice job on the selinux integration, I see you fixed the packaging draft too :) I will try to do the formal review by Tuesday morning if you're ready by then. I still want to look into the setup/installation before then. Oops, my patch tests for <= "5" but it should have been < "5". You probably want to fix that. I didn't have an EL5 to build against to check if the dependencies were right. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review