Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 Nikita Klimov <nk@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nk@xxxxxxx --- Comment #9 from Nikita Klimov <nk@xxxxxxx> --- Hi Vasiliy - libzen should be released with zlib/libpng license. Why are you using LGPLv3 in spec file? - Please add short informative comments in %{build} and %{install} section - " The package must be consistent. For any given path, within the same spec, use either a hard-coded path or a macro, not a combination of the two. " https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#macros A good solution will use %{name} macro where you can. - In my opinion it's not necessary in spec file: 42 # Fix up Makefile.am 43 cat << EOF >> Project/GNU/Library/Makefile.am 44 45 bin_SCRIPTS = libzen-config 46 47 pkgconfigdir = \$(libdir)/pkgconfig 48 pkgconfig_DATA = libzen.pc 49 50 EOF Upstream file also included this lines, and you are simply doubled it. - Please remove Russian Fedora tags in %{changelog} section. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9733dfMjMG&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review