Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #16 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- I'm pasting the result of a semi-automated, hand-edited review (using the "fedora-review" tool): Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/michich/927269-xorg-x11-glamor/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. NOTE: "xorg-x11-glamor" is not identical to the upstream project/tarball/repository name, but it matches the xorg-x11-* naming pattern used in Fedora. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. NOTE: The multiple ownership of /usr/include/xorg is fine. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. NOTE: http://koji.fedoraproject.org/koji/taskinfo?taskID=5218479 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xorg-x11-glamor-0.5.0-4.20130401git81aadb8.fc20.x86_64.rpm xorg-x11-glamor-devel-0.5.0-4.20130401git81aadb8.fc20.x86_64.rpm xorg-x11-glamor.x86_64: W: shared-lib-calls-exit /usr/lib64/libglamor.so.0.0.0 exit@GLIBC_2.2.5 xorg-x11-glamor-devel.x86_64: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er xorg-x11-glamor-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint xorg-x11-glamor-devel xorg-x11-glamor xorg-x11-glamor-devel.x86_64: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er xorg-x11-glamor-devel.x86_64: W: no-documentation xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 serverClient xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionEmptyData xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 PictureScreenPrivateKeyRec xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 PixmapWidthPaddingInfo xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionEmptyBox xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miChangeGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCopyGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDestroyGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miChangeClip xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDestroyClip xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCopyClip xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyRectangle xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyArc xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miFillPolygon xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyFillArc xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyText8 xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyText16 xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miImageText8 xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miImageText16 xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionAppend xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDoCopy xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCopyPlane xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyGlyphBlt xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miImageGlyphBlt xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionDestroy xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbComposite xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegisterBlockAndWakeupHandlers xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 LogMessageVerb xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbGetImage xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_rasterize_trapezoid xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 ValidatePicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbGetSpans xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyPoint xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbAddTraps xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 ValidateGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbDestroyPixmap xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 dixRegisterPrivateKey xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 XNFasprintf xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionCreate xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCompositeRects xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 GetScratchGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 FreeScratchGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbValidateGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_rectangles xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_contains_rectangle xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 CreatePicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCreatePicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDestroyPicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_unref xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_init_rects xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fb24_32ReformatTile xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_extents xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPushPixels xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCopyNtoN xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 PictureMatchFormat xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCreatePixmap xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCreateGC xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_union xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbTriangles xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPolyLine xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_init_with_extents xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_egl_restore_context xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbFill xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_gl_dispatch_init xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbSetSpans xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miGetImage xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionValidate xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 FatalError xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPadPixmap xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_intersect xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_create_bits xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_f_transform_point xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 DamageRegionAppend xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miComputeCompositeRegion xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPolyFillRect xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 LogMessage xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 CompositePicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_transform_is_int_translate xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_f_transform_from_pixman_transform xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miRenderColorToPixel xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_copy xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_get_data xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 DamageRegionProcessPending xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_composite xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_egl_make_current xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 FreePicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_egl_screen_init xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCopyRegion xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 CreateSolidPicture xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_translate xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_init xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolySegment xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbFillSpans xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_fini xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPixmapToRegion xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPutImage xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miTrapezoidBounds xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 ErrorF xorg-x11-glamor.x86_64: W: shared-lib-calls-exit /usr/lib64/libglamor.so.0.0.0 exit@GLIBC_2.2.5 2 packages and 0 specfiles checked; 0 errors, 101 warnings. # echo 'rpmlint-done:' Requires -------- xorg-x11-glamor-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libglamor.so.0()(64bit) xorg-x11-glamor(x86-64) xorg-x11-glamor (rpmlib, GLIBC filtered): /sbin/ldconfig libEGL.so.1()(64bit) libGL.so.1()(64bit) libc.so.6()(64bit) libglamor.so.0()(64bit) rtld(GNU_HASH) xorg-x11-server-Xorg Provides -------- xorg-x11-glamor-devel: pkgconfig(glamor) pkgconfig(glamor-egl) xorg-x11-glamor-devel xorg-x11-glamor-devel(x86-64) xorg-x11-glamor: libglamor.so.0()(64bit) libglamoregl.so()(64bit) xorg-x11-glamor xorg-x11-glamor(x86-64) Unversioned so-files -------------------- xorg-x11-glamor: /usr/lib64/xorg/modules/libglamoregl.so Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 927269 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t0YsithTgE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review