[Bug 948345] Review Request: mozjs17 - JavaScript interpreter and libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948345

--- Comment #3 from Kalev Lember <kalevlember@xxxxxxxxx> ---
> > Does it really need ncurses/readline headers? I couldn't find any
> > ncurses/readline includes in the js header files, at least.

Just to clarify, I wasn't talking about BuildRequires. I was talking about the
-devel package's runtime requires on the ncurses/readline headers. The
dependency seemed to indicate that the ncurses/readline headers need to be
present to use the installed js public headers. I was just objecting to that
and saying that the public headers (in the -devel package) don't appear to
include anything else besides glibc headers.


> Looks like it has an internal copy of editline =/
> 
> I will work on de-bundling this.

Cool!

Is the internal editline only used for building the command line "js17"
interpreter?

>From the spec file:
> # Not clear to me we should ship this at all really,
> # but the real problem is it is statically linked
> # which bloats it significantly.
> rm -f %{buildroot}%{_bindir}/js17

I guess statically linking with internal editline can account for some of the
bloat.

If you want to avoid shipping the js17 executable in any case, then it doesn't
really matter for Fedora if the tarball has an internal editline or not. If we
remove the binary, we aren't shipping the statically linked internal copy
anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8l4Btsxyf9&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]