[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948105

--- Comment #6 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> ---
For -2:

* Requires etc
  - On F-19+, rubygem-based rpm must have "Requires: ruby(release)"
    and On F-18-, rubygem-based rpm must have "Requires: ruby(abi) = 1.9.1".
    One trick is
%if 0%{?fedora} >= 19
Requires: ruby(release)
%else
Requires: ruby(abi) = 1.9.1
%endif

* Documentation
  - What I meant is that %gem_instdir/AUTHORS and etc should be marked as %doc.
    Currently these files (%gem_instdir/AUTHORS, %gem_instdir/CHANGES, etc)
    are not marked as %doc, and the same files are copied into
    /usr/share/doc/%{name}-%{version} (with marked as doc).

    It is recommended to write %files entry more verbosely, like
%files
%dir %{gem_instdir}
%doc %{gem_instdir}/[A-Z]*
%{gem_libdir}
%{gem_instdir}/foobar
....

  - Also, rm -rf %{buildroot}%{gem_dir}/{INSTALLING,Rakefile,test} should be
    rm -rf %{buildroot}%{gem_instdir}/{INSTALLING,Rakefile,test}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dmGss9ysso&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]