[Bug 911042] Review Request: nodejs-node-uuid - Simple and fast generation of RFC4122 (v1 and v4) UUIDs for Node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911042

T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review+              |
              Flags|                            |fedora-review?

--- Comment #3 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
Ugh, spoke too soon. There are a few concerning rpmlint warnings:

nodejs-node-uuid.noarch: W: devel-file-in-non-devel-package
/usr/libexec/node-uuid/benchmark/benchmark-native.c
nodejs-node-uuid.noarch: E: wrong-script-interpreter
/usr/libexec/node-uuid/benchmark/bench.gnu /opt/local/bin/gnuplot
nodejs-node-uuid.noarch: E: non-executable-script
/usr/libexec/node-uuid/benchmark/bench.gnu 0644L /opt/local/bin/gnuplot

Do you really need to ship the benchmark stuff in the package?  It doesn't seem
like it's really useful.

If so, it should probably be in a subpackage that has dependencies on gnuplot. 
You'll also need to fix up the shebang and executable bit complained about
above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KITrPk6aAe&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]