Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889505 Alec Leamas <leamas.alec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.alec@xxxxxxxxx --- Comment #16 from Alec Leamas <leamas.alec@xxxxxxxxx> --- In comment #13 you set cflags to "$cflags -fpic". How will this ensure that %{optflags} is applied? Stated otherwise: if you check the build logs and compares it with the output from 'rpm --eval %optflags', can you verify that %optflags is applied? See also [1] Patching or adding a COPYING file isn't kosher, only the copyright owner can do that. You should file a bug upstream about the missing COPYING, leaving source as-is until upstream fixes this. See also [2]. The normal way to handle the other stuff is to use the upstream sources and create patches as needed. However, instead of using the upstream source from http://mark.heily.com/project/libkqueue you have created an own archive, effectively forking the project. Forking isn't necessary evil, but requires an explanation beyond the review remarks discussed so far. So: why have you forked the upstream project? [1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#debuginfo-without-sources [2] https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ukZ1GO4WPd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review